[PATCH] D74416: [llvm][TextAPI] add simulators to output
Cyndy Ishida via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 11 08:44:49 PST 2020
cishida added inline comments.
================
Comment at: llvm/lib/TextAPI/MachO/TextStubCommon.cpp:68
break;
+ case PlatformKind::iOSSimulator:
+ OS << "ios";
----------------
ributzka wrote:
> You could simplify this to use fall-throughs for all the simulator platforms.
wouldn't that trigger a warning with `-Wimplicit-fallthrough`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74416/new/
https://reviews.llvm.org/D74416
More information about the llvm-commits
mailing list