[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

[Paul Robinson via Phabricator via llvm-commits]

probinson accepted this revision.
probinson added a comment.

Functionally looks fine, see where I think the commentary should be adjusted.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:427
+  // The EmitDwarfDebugEntryValues should be used only for testing purposes
+  // when a debugger does not support the debug entry values.
+  EmitDebugEntryValues = (Asm->TM.Options.ShouldEmitDebugEntryValues() &&
----------------
`Emit call-site-param debug info for GDB and LLDB, if the target supports it.  Can also be enabled explicitly.`


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:850
+      // The call-site-param debug info is used for printing the debug entry
+      // values.
+      if (emitDebugEntryValues()) {
----------------
`Optionally emit call-site-param debug info.`
(This is no longer the place where the gdb/lldb decision is made.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73534/new/

https://reviews.llvm.org/D73534