[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

lgtm with a nit, but please wait for @probinson to confirm that the debugger tuning issue is sorted out.



================
Comment at: llvm/test/DebugInfo/X86/loclists-dwp.ll:23
+; CHECK-NEXT: DW_LLE_startx_length (0x0000000000000000, 0x0000000000000006): DW_OP_reg5 RDI
+; CHECK-NEXT: DW_LLE_startx_length (0x0000000000000001, 0x0000000000000002): DW_OP_GNU_entry_value(DW_OP_reg5 RDI), DW_OP_stack_value)
 
----------------
nice :)


================
Comment at: llvm/test/DebugInfo/X86/no-entry-values-with-O0.ll:6
+
+; CHECK-NOT: DW_TAG_call_site_param
+
----------------
Please add a note here explaining that entry values /would/ get emitted if the 'AllCallsDescribed' DIFlag was set on fn1's subprogram.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73534/new/

https://reviews.llvm.org/D73534