[PATCH] D74391: [llvm-readelf] Match GNU readelf more more closely when dumping notes

[Alexander Richardson via Phabricator via llvm-commits]

arichardson created this revision.
arichardson added reviewers: rupprecht, jhenderson, MaskRay.
Herald added subscribers: llvm-commits, kerbowa, nhaehnle, jvesely, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

GNU readelf prints "Unknown note type: (0x00000003)", whereas we were
omitting the colon. Additonally for unknown notes GNU readelf prints
"    Description data:" whereas we were using a lowercase d and missing
one space of indentation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74391

Files:
  lld/test/ELF/partition-notes.s
  llvm/test/CodeGen/AMDGPU/elf-notes.ll
  llvm/test/tools/llvm-readobj/ELF/note-freebsd.s
  llvm/test/tools/llvm-readobj/ELF/note-unknown.s
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74391.243769.patch
Type: text/x-patch
Size: 6032 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200211/2bbe92fd/attachment.bin>