[PATCH] D74370: [mlir] [VectorOps] Implement vector.reduce operation

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache accepted this revision.
nicolasvasilache added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/VectorOps/VectorOps.td:210
+  let assemblyFormat = [{
+    $kind `,` $vector attr-dict `:` type($vector) `into` type($dest)
+  }];
----------------
if we had better dependent type support, would we want to drop the `into f32` part of the op?


================
Comment at: mlir/test/Dialect/VectorOps/invalid.mlir:998
+  // expected-error at +1 {{'vector.reduction' op unknown reduction kind: joho}}
+  %0 = vector.reduction "joho", %arg0 : vector<16xf32> into f32
+}
----------------
what's a "joho" ? :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74370/new/

https://reviews.llvm.org/D74370