[PATCH] D74370: [mlir] [VectorOps] Implement vector.reduce operation

[Aart Bik via Phabricator via llvm-commits]

aartbik added inline comments.


================
Comment at: mlir/include/mlir/Dialect/VectorOps/VectorOps.td:203
+    ```
+      %1 = vector.reduction "add", %0 : vector<16xf32>
+
----------------
rriddle wrote:
> Looks like you are missing the `into type` on these examples.
Good eye! Thanks for noticing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74370/new/

https://reviews.llvm.org/D74370