[PATCH] D73907: [InstCombine] correct operands of shouldChangeType() for casted phi transform

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D73907#1866565 <https://reviews.llvm.org/D73907#1866565>, @courbet wrote:

> > "opt -codegenprepare":
>
> I think you meant `llc`.


With CGP, we can use either llc or opt to test, but if the bug is visible/reproducible with opt, then it's better to use that invocation. That's because the regression test can then be an IR --> IR test, and that is (almost?) always simpler to test/understand than IR --> some-other-language.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73907/new/

https://reviews.llvm.org/D73907