[PATCH] D73907: [InstCombine] correct operands of shouldChangeType() for casted phi transform

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

> "opt -codegenprepare":

I think you meant `llc`. Thanks for the repro. `D73274` is indeed responsible for the crash, but it only exhibited an issue with the existing code: An alignment of `1` was previously silently changed to an alignment of `0`. The new typed `Align` catches this: When splitting a 1-aligned store into two stores, both stores are 1-aligned, instead of one being 1-aligned and the other being 0-aligned (which does not really mean anything since it has different semantics depending on where you are in LLVM)

I'll send a fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73907/new/

https://reviews.llvm.org/D73907