[PATCH] D74230: GlobalISel: Fix narrowing of G_CTLZ/G_CTTZ
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 9 15:46:39 PST 2020
arsenm closed this revision.
arsenm marked an inline comment as done.
arsenm added a comment.
6135f5eda48eb12a98f835d976e4916cfd44764c <https://reviews.llvm.org/rG6135f5eda48eb12a98f835d976e4916cfd44764c>
================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp:101
+ DefineLegalizerInfo(A, {
+ getActionDefinitionsBuilder(G_CTLZ).legalFor({{s32, s64}});
+ });
----------------
Petar.Avramovic wrote:
> This does not seem to have any effect but shouldn't second type be s32 since narrow scalar uses s32?
The legalizer info isn't really needed at all in any of these tests since the action is explicitly called
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74230/new/
https://reviews.llvm.org/D74230
More information about the llvm-commits
mailing list