[PATCH] D74230: GlobalISel: Fix narrowing of G_CTLZ/G_CTTZ

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 7 10:35:44 PST 2020


Petar.Avramovic accepted this revision.
Petar.Avramovic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp:101
+  DefineLegalizerInfo(A, {
+    getActionDefinitionsBuilder(G_CTLZ).legalFor({{s32, s64}});
+  });
----------------
This does not seem to have any effect but shouldn't second type be s32 since narrow scalar uses s32? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74230/new/

https://reviews.llvm.org/D74230





More information about the llvm-commits mailing list