[PATCH] D74170: AMDGPU/GlobalISel: Don't mis-select vector index on a constant

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:1967
     = AMDGPU::getBaseWithConstantOffset(MRI, IdxReg);
+  if (IdxBaseReg == AMDGPU::NoRegister) {
+    // This will happen if the index is a known constant. This should ordinarily
----------------
kerbowa wrote:
> Can this just assert?
The point is to not assert or crash. We can handle this here, so it should just work


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74170/new/

https://reviews.llvm.org/D74170