[PATCH] D74170: AMDGPU/GlobalISel: Don't mis-select vector index on a constant

Austin Kerbow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 8 23:01:27 PST 2020


kerbowa added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:1967
     = AMDGPU::getBaseWithConstantOffset(MRI, IdxReg);
+  if (IdxBaseReg == AMDGPU::NoRegister) {
+    // This will happen if the index is a known constant. This should ordinarily
----------------
Can this just assert?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74170/new/

https://reviews.llvm.org/D74170





More information about the llvm-commits mailing list