[PATCH] D74006: [MC][ELF] Make linked-to symbol name part of ELFSectionKey

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 9 10:11:59 PST 2020


MaskRay updated this revision to Diff 243453.
MaskRay marked an inline comment as done.
MaskRay added a comment.

Rebase after D74082 <https://reviews.llvm.org/D74082> was committed

My current thoughts regarding (.section directives with the same name but different fields)
are similar to binutils' (eventual) state:

- sh_flags or sh_type: warn
- sh_link/group name: no warning. produce separate sections
- sh_entsize due to SHF_MERGE: still controversial. I am slightly inclined to require ,unique


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74006/new/

https://reviews.llvm.org/D74006

Files:
  llvm/include/llvm/MC/MCContext.h
  llvm/lib/MC/MCContext.cpp
  llvm/test/MC/ELF/comdat-dup-group-name.s
  llvm/test/MC/ELF/section-combine.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74006.243453.patch
Type: text/x-patch
Size: 5404 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200209/0e344efd/attachment-0001.bin>


More information about the llvm-commits mailing list