[PATCH] D73853: [llvm-reduce] add ReduceAttribute delta pass

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 9 01:51:37 PST 2020


nickdesaulniers marked 2 inline comments as done.
nickdesaulniers added inline comments.


================
Comment at: llvm/test/Reduce/remove-attributes.ll:3
+;
+; RUN: rm -rf %t
+; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-attributes.py %s -o %t
----------------
MaskRay wrote:
> `rm -rf` frightens me.
> 
> `rm -f` is sufficient.
> 
> Mac is failing.. http://45.33.8.238/mac/7303/step_11.txt
Hmmm...I'm not sure why I cannot reproduce.


================
Comment at: llvm/test/Reduce/remove-attributes.ll:5
+; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-attributes.py %s -o %t
+; RUN: cat %t | FileCheck  %s
+
----------------
MaskRay wrote:
> `FileCheck --input-file=`  or `FileCheck < `
No other tests in this dir do that. It's required?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73853/new/

https://reviews.llvm.org/D73853





More information about the llvm-commits mailing list