[PATCH] D73853: [llvm-reduce] add ReduceAttribute delta pass

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 10:52:16 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/test/Reduce/remove-attributes.ll:3
+;
+; RUN: rm -rf %t
+; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-attributes.py %s -o %t
----------------
`rm -rf` frightens me.

`rm -f` is sufficient.

Mac is failing.. http://45.33.8.238/mac/7303/step_11.txt


================
Comment at: llvm/test/Reduce/remove-attributes.ll:5
+; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-attributes.py %s -o %t
+; RUN: cat %t | FileCheck  %s
+
----------------
`FileCheck --input-file=`  or `FileCheck < `


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73853/new/

https://reviews.llvm.org/D73853





More information about the llvm-commits mailing list