[PATCH] D74198: [DebugInfo] Add support for DWARF64 into DWARFDebugAddr.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin marked 2 inline comments as done.
ikudrin added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugAddr.cpp:68
+  } else if (Length >= dwarf::DW_LENGTH_lo_reserved) {
+    uint64_t TmpLength = Length;
     invalidateLength();
----------------
aprantl wrote:
> DiagnosticLength?
Thanks! I'll change the name, as well as for the other similar instances.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugAddr.cpp:159
+  if (Length) {
+    int LengthFieldWidth = (Format == dwarf::DwarfFormat::DWARF64) ? 16 : 8;
+    OS << format("Address table header: length = 0x%0*" PRIx64
----------------
aprantl wrote:
> unsigned?
Could you explain why `unsinged` is better than `int` here?

Note that according to http://www.cplusplus.com/reference/cstdio/printf/,

> *: The width is not specified in the format string, but as an additional integer value argument preceding the argument that has to be formatted.

Not "an unsigned integer value".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74198/new/

https://reviews.llvm.org/D74198