[PATCH] D74198: [DebugInfo] Add support for DWARF64 into DWARFDebugAddr.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a subscriber: labath.
dblaikie added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugAddr.cpp:55-75
   if (Length == dwarf::DW_LENGTH_DWARF64) {
+    // Check that we can read the extended unit length field.
+    if (!Data.isValidOffsetForDataOfSize(Offset, 8)) {
+      invalidateLength();
+      return createStringError(
+          errc::invalid_argument,
+          "section is not large enough to contain a .debug_addr table "
----------------
@labath another instance of this 32/64 length parsing/error dance and subsequent "isValid" checking following it that'd be great to tidy up with a common utility for parsing the length and returning a length-constrained DWARFDataExtractor for further use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74198/new/

https://reviews.llvm.org/D74198