[PATCH] D74221: [TargetLowering] Add NegatibleKind enum for isNegatibleForFree return codes

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 7 07:06:14 PST 2020


RKSimon created this revision.
RKSimon added reviewers: xbolva00, arsenm, spatel, lebedev.ri.
Herald added subscribers: kerbowa, hiraditya, nhaehnle, wdng, jvesely.
Herald added a project: LLVM.

The isNegatibleForFree/getNegatedExpression methods currently rely on a raw char value to indicate whether a negation is beneficial or not.

This patch replaces the char return value with an NegatibleKind enum to more clearly demonstrate what is implied.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74221

Files:
  llvm/include/llvm/CodeGen/TargetLowering.h
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/lib/Target/X86/X86ISelLowering.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74221.243159.patch
Type: text/x-patch
Size: 22986 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200207/70ad66ac/attachment.bin>


More information about the llvm-commits mailing list