[PATCH] D74075: [mlir][VectorOps] Introduce a `vector.fma` op that works on n-D vectors and lowers to `llvm.intrin.fmuladd`

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 7 06:20:55 PST 2020


nicolasvasilache marked an inline comment as done.
nicolasvasilache added a comment.

> Is there a way to remove your blocking review but without approving yet? I don't see that option here.
>  Anyway, please look at the other comments that are still open.

@aartbik that's fine, I still need to expose the fma intrinsic from LLVM and use it in this revision, `fmuladd` is not the right thing as @fhahn 's comment made me realize.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74075/new/

https://reviews.llvm.org/D74075





More information about the llvm-commits mailing list