[PATCH] D73692: [PowerPC] Fix spilling of vector registers in PEI of EH aware functions
Victor Huang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 5 12:53:47 PST 2020
NeHuang added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.h:293
+ void storeRegToStackSlotNoUpd(MachineBasicBlock &MBB,
+ MachineBasicBlock::iterator MBBI,
----------------
nit: IMHO it could be better to add descriptions/comments on `NoUpd` for the two new functions `storeRegToStackSlotNoUpd` and `loadRegFromStackSlotNoUpd`?
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.h:305
+ void loadRegFromStackSlotNoUpd(MachineBasicBlock &MBB,
+ MachineBasicBlock::iterator MBBI,
----------------
same as 293
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73692/new/
https://reviews.llvm.org/D73692
More information about the llvm-commits
mailing list