[PATCH] D73713: Fixed non-deterministic GPU intrinsic lowering.

[Stephan Herhut via Phabricator via llvm-commits]

herhut added a comment.

In D73713#1858103 <https://reviews.llvm.org/D73713#1858103>, @mehdi_amini wrote:

> In D73713#1856579 <https://reviews.llvm.org/D73713#1856579>, @herhut wrote:
>
> > Let's use dynamicallyIllegalOp instead to disallow the CPU intrinsic explicitly. That would also make the non-determinism go away by not relying on pattern order anymore. And it also captures the actual issue that the intrinsics call is indeed illegal.
>
>
> IIUC: This does not address the underlying issue with the framework though, it seems to still be in the category of "hiding the bug".


No and no. It will not fix the underlying non-determinism issue, so that will have to be addressed. Independently, we should not rely on pattern insertion order for correctness either. So we should exclude the rewriting to LLVM intrinsics that are not available.

So let's get this correct and also fix the underlying issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73713/new/

https://reviews.llvm.org/D73713