[PATCH] D73713: Fixed non-deterministic GPU intrinsic lowering.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 15:28:01 PST 2020


mehdi_amini added a comment.

In D73713#1856579 <https://reviews.llvm.org/D73713#1856579>, @herhut wrote:

> Let's use dynamicallyIllegalOp instead to disallow the CPU intrinsic explicitly. That would also make the non-determinism go away by not relying on pattern order anymore. And it also captures the actual issue that the intrinsics call is indeed illegal.


IIUC: This does not address the underlying issue with the framework though, it seems to still be in the category of "hiding the bug".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73713/new/

https://reviews.llvm.org/D73713





More information about the llvm-commits mailing list