[PATCH] D74005: [GlobalISel][AArch64] Fix contract cross-bank copies with SIMD instructions

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 17:08:42 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:303
 
-llvm::MachineInstr *llvm::getDefIgnoringCopies(Register Reg,
-                                               const MachineRegisterInfo &MRI) {
+struct DefinitionAndSourceRegister {
+  llvm::MachineInstr *MI;
----------------
```
namespace {
struct ...
}
```

per https://llvm.org/docs/CodingStandards.html#anonymous-namespaces


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:324
   }
-  return DefMI;
+  return DefinitionAndSourceRegister{ DefMI, DefSrcReg };
+}
----------------
`{ ` -> `{`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74005/new/

https://reviews.llvm.org/D74005





More information about the llvm-commits mailing list