[PATCH] D74005: [GlobalISel][AArch64] Fix contract cross-bank copies with SIMD instructions

[Shu-Chun Weng via Phabricator via llvm-commits]

scw marked an inline comment as done.
scw added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:303-304
 
-llvm::MachineInstr *llvm::getDefIgnoringCopies(Register Reg,
-                                               const MachineRegisterInfo &MRI) {
+static std::pair<llvm::MachineInstr *, Register> getDefSrcRegIgnoringCopies(
+    Register Reg,
+    const MachineRegisterInfo &MRI) {
----------------
paquette wrote:
> Instead of a std::pair, can we do something similar to `getConstantVRegValWithLookThrough`, which returns an Optional struct?
> 
> Then when we bail out, we can just return None, which is a little nicer IMO.
Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74005/new/

https://reviews.llvm.org/D74005