[PATCH] D71593: [DebugInfo] Call site entries cannot be generated for FrameSetup calls

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In D71593#1857072 <https://reviews.llvm.org/D71593#1857072>, @lewis-revill wrote:

> In D71593#1851876 <https://reviews.llvm.org/D71593#1851876>, @probinson wrote:
>
> > It's hard for me to imagine a case where a frame-setup prologue requires a call that really wants debug info.  For the save/restore example in D62686 <https://reviews.llvm.org/D62686>, the calls are to system/library helpers to support a size optimization, and as such seem like an implementation detail (along the lines of, say, implementing integer divide as a lib call when you don't have a hardware instruction).  So, skipping FrameSetup instructions seems like the right tactic, although the justification in the comment isn't really the right reason.
>
>
> What should the comment say?


Currently, the comment implies that we *would* want to handle these calls, except that we don't have a piece of infrastructure in place yet (i.e., the missing labels).  That is, it reads like a FIXME remark.  IMO we don't want to handle these calls, even if we did have those labels; that is, skipping these calls is always the right thing to do.  I would write the comment as something like:
`// Skip instructions marked as frame setup, as they are not interesting to the user.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71593/new/

https://reviews.llvm.org/D71593