[PATCH] D71593: [DebugInfo] Call site entries cannot be generated for FrameSetup calls

Tue Feb 4 07:45:47 PST 2020

lewis-revill added a comment.

Thanks all for the feedback, I'll make this patch depend upon the save/restore feature so that I can add a testcase.

In D71593#1851876 <https://reviews.llvm.org/D71593#1851876>, @probinson wrote:

> It's hard for me to imagine a case where a frame-setup prologue requires a call that really wants debug info.  For the save/restore example in D62686 <https://reviews.llvm.org/D62686>, the calls are to system/library helpers to support a size optimization, and as such seem like an implementation detail (along the lines of, say, implementing integer divide as a lib call when you don't have a hardware instruction).  So, skipping FrameSetup instructions seems like the right tactic, although the justification in the comment isn't really the right reason.

What should the comment say?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71593/new/

https://reviews.llvm.org/D71593