[PATCH] D73950: [AArch64] Make Read Write System Registers Read Only

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/test/MC/AArch64/armv8.2a-statistical-profiling.s:7
+
+// NO_SPE_OUT-NOT: {{msr}}
 
----------------
LukeGeeson wrote:
> ostannard wrote:
> > Why are you just checking `msr`, and not `mrs` or `psb`?
> good spot, fixed
This is now checking that the string `msr, mrs, psb` doesn't appear in the output, which isn't what we want to test. It also doesn't need the regex. Something like this would work (not actually tested):

  // NO_SPE_OUT-NOT: msr
  // NO_SPE_OUT-NOT: mrs
  // NO_SPE_OUT-NOT: psb


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73950/new/

https://reviews.llvm.org/D73950