[PATCH] D73950: [AArch64] Make Read Write System Registers Read Only

[Luke Geeson via Phabricator via llvm-commits]

LukeGeeson marked 8 inline comments as done.
LukeGeeson added inline comments.


================
Comment at: llvm/test/MC/AArch64/armv8.2a-statistical-profiling.s:1
-// RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+spe < %s | FileCheck %s
-// RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mcpu=neoverse-n1 < %s | FileCheck %s
-// RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding < %s 2>&1 | FileCheck --check-prefix=NO_SPE %s
+// RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+spe       < %s 2> %t | FileCheck %s
+// RUN: not llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mcpu=neoverse-n1 < %s 2> %t | FileCheck %s
----------------
ostannard wrote:
> The stderr from this llvm-mc execution is redirected to a temp file, but not checked.
added FileCheck command


================
Comment at: llvm/test/MC/AArch64/armv8.2a-statistical-profiling.s:7
+
+// NO_SPE_OUT-NOT: {{msr}}
 
----------------
ostannard wrote:
> Why are you just checking `msr`, and not `mrs` or `psb`?
good spot, fixed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73950/new/

https://reviews.llvm.org/D73950