[PATCH] D71774: [RISCV] Optimize seteq/setne pattern expansions for better code size

Tue Feb 4 05:56:06 PST 2020

lenary accepted this revision.
lenary added a comment.
This revision is now accepted and ready to land.

In D71774#1856710 <https://reviews.llvm.org/D71774#1856710>, @lewis-revill wrote:

> In D71774#1821760 <https://reviews.llvm.org/D71774#1821760>, @lenary wrote:
>
> > Have you seen any regressions in code generation from this change?
>
>
> That's a fair comment, though I'd hope the situation where the result of the xor in this pattern is used for anything else later on would be extremely rare/impossible?

Ah, yes, that does make sense, given the `addi` is generated with one use.

I'm happy for this to land now!

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71774/new/

https://reviews.llvm.org/D71774