[PATCH] D71774: [RISCV] Optimize seteq/setne pattern expansions for better code size
Lewis Revill via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 4 05:01:37 PST 2020
lewis-revill added a comment.
In D71774#1821760 <https://reviews.llvm.org/D71774#1821760>, @lenary wrote:
> This seems like a fun issue:
>
> - `addi` is compressible
> - `xor` is almost certainly easier to analyse (from the view of `KnownBits` and the like).
>
> Have you seen any regressions in code generation from this change?
That's a fair comment, though I'd hope the situation where the result of the xor in this pattern is used for anything else later on would be extremely rare/impossible?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71774/new/
https://reviews.llvm.org/D71774
More information about the llvm-commits
mailing list