[PATCH] D73788: [yaml2obj/obj2yaml] - Add support for the SHT_LLVM_CALL_GRAPH_PROFILE sections.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 02:15:49 PST 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:703
+  // Dump the section by using the Content key when it is truncated.
+  // There is no need to create neither "Content" nor "Entries" fields when the
+  // section is empty.
----------------
jhenderson wrote:
> neither/nor -> either/or (in this context - the "no" provides the negation, making it unnecessary here).
Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73788/new/

https://reviews.llvm.org/D73788





More information about the llvm-commits mailing list