[PATCH] D73788: [yaml2obj/obj2yaml] - Add support for the SHT_LLVM_CALL_GRAPH_PROFILE sections.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 4 01:53:23 PST 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with nit.
================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:703
+ // Dump the section by using the Content key when it is truncated.
+ // There is no need to create neither "Content" nor "Entries" fields when the
+ // section is empty.
----------------
neither/nor -> either/or (in this context - the "no" provides the negation, making it unnecessary here).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73788/new/
https://reviews.llvm.org/D73788
More information about the llvm-commits
mailing list