[PATCH] D73707: [TSAN] Parameterize the hard-coded threshold of deflake in tsan test

Anh Tuyen Tran via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 18:31:35 PST 2020


anhtuyen marked an inline comment as done.
anhtuyen added inline comments.


================
Comment at: compiler-rt/test/tsan/deflake.bash:17
+# Early exit if $THRESHOLD is not a non-negative integer
+[[  "${THRESHOLD}" =~ ^[0-9]+$ ]] || exit 1
+
----------------
vitalybuka wrote:
> why do you need this?
> 
> I'd expect
> ```
> for i in $(seq 1 ${THRESHOLD}); do
> ```
> already exits with error
Hi Vitaly @vitalybuka 
Thank you very much for your review and acceptance. 
The condition 
```
[[  "${THRESHOLD}" =~ ^[0-9]+$ ]] || exit 1
``` 
is to exit early for cases such as that of a negative value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73707/new/

https://reviews.llvm.org/D73707





More information about the llvm-commits mailing list