[PATCH] D73707: [TSAN] Parameterize the hard-coded threshold of deflake in tsan test

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 18:13:19 PST 2020


vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: compiler-rt/test/tsan/deflake.bash:17
+# Early exit if $THRESHOLD is not a non-negative integer
+[[  "${THRESHOLD}" =~ ^[0-9]+$ ]] || exit 1
+
----------------
why do you need this?

I'd expect
```
for i in $(seq 1 ${THRESHOLD}); do
```
already exits with error


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73707/new/

https://reviews.llvm.org/D73707





More information about the llvm-commits mailing list