[PATCH] D70247: [JumpThreading] Thread jumps through two basic blocks

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:2119
+  // Don't thread across a loop header.
+  if (LoopHeaders.count(PredBB))
+    return false;
----------------
kazu wrote:
> xbolva00 wrote:
> > Can you allow this if ThreadAcrossLoopHeaders is set?
> Actually, we already allow the transformation if ThreadAcrossLoopHeaders is set.
> 
> If ThreadAcrossLoopHeaders is set, we don't call FindLoopHeaders in JumpThreadingPass::runImpl, so LoopHeaders remains empty.
Oh, okay, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70247/new/

https://reviews.llvm.org/D70247