[PATCH] D70247: [JumpThreading] Thread jumps through two basic blocks

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 3 12:36:36 PST 2020


kazu marked an inline comment as done.
kazu added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:2119
+  // Don't thread across a loop header.
+  if (LoopHeaders.count(PredBB))
+    return false;
----------------
xbolva00 wrote:
> Can you allow this if ThreadAcrossLoopHeaders is set?
Actually, we already allow the transformation if ThreadAcrossLoopHeaders is set.

If ThreadAcrossLoopHeaders is set, we don't call FindLoopHeaders in JumpThreadingPass::runImpl, so LoopHeaders remains empty.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70247/new/

https://reviews.llvm.org/D70247





More information about the llvm-commits mailing list