[PATCH] D73890: Fix a -Wbitwise-conditional-parentheses warning in _LIBUNWIND_ARM_EHABI libunwind builds
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 3 11:20:06 PST 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG221c5af4e4f4: Fix a -Wbitwise-conditional-parentheses warning in _LIBUNWIND_ARM_EHABIā¦ (authored by thakis).
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73890/new/
https://reviews.llvm.org/D73890
Files:
libunwind/src/UnwindCursor.hpp
Index: libunwind/src/UnwindCursor.hpp
===================================================================
--- libunwind/src/UnwindCursor.hpp
+++ libunwind/src/UnwindCursor.hpp
@@ -1353,7 +1353,8 @@
// If the high bit is set, the exception handling table entry is inline inside
// the index table entry on the second word (aka |indexDataAddr|). Otherwise,
- // the table points at an offset in the exception handling table (section 5 EHABI).
+ // the table points at an offset in the exception handling table (section 5
+ // EHABI).
pint_t exceptionTableAddr;
uint32_t exceptionTableData;
bool isSingleWordEHT;
@@ -1452,7 +1453,7 @@
_info.unwind_info = exceptionTableAddr;
_info.lsda = lsda;
// flags is pr_cache.additional. See EHABI #7.2 for definition of bit 0.
- _info.flags = isSingleWordEHT ? 1 : 0 | scope32 ? 0x2 : 0; // Use enum?
+ _info.flags = (isSingleWordEHT ? 1 : 0) | (scope32 ? 0x2 : 0); // Use enum?
return true;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73890.242137.patch
Type: text/x-patch
Size: 970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200203/0ad0f77c/attachment.bin>
More information about the llvm-commits
mailing list