[PATCH] D73714: [DWARF] Do not cut 64-bit values when dumping CIEs and FDEs.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin updated this revision to Diff 242053.
ikudrin added a comment.

- Fix the printing field length of CIE pointer for FDEs in .eh_frame.
- Keep the actual value of the CIE Id field.

I have to mention that I fell a bit uncomfortable storing a constant value that can be easily reconstructed. I prepared another patch which uses another approach to guarantee that the reading and dumping values are the same. Please, take a look at D73887 <https://reviews.llvm.org/D73887> and tell me which variant you like better; I will abandon the other one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73714/new/

https://reviews.llvm.org/D73714

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h
  llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
  llvm/test/tools/llvm-dwarfdump/X86/debug_frame_offset.test
  llvm/test/tools/llvm-objdump/eh_frame-arm64.test
  llvm/unittests/DebugInfo/DWARF/CMakeLists.txt
  llvm/unittests/DebugInfo/DWARF/DWARFDebugFrameTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73714.242053.patch
Type: text/x-patch
Size: 13551 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200203/733e4ed8/attachment.bin>