[PATCH] D73804: [GVN] Add GVNOption to control load-pre more fine-grained.

Fri Jan 31 14:44:48 PST 2020

fhahn added inline comments.

================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1406
     return false;
+  if (!isLoadInLoopPREEnabled() && this->LI &&
+      this->LI->getLoopFor(LI->getParent()))
----------------
hgreving wrote:
> fhahn wrote:
> > nit: drop unnecessary this-> ?
> This is testing the LoopInfo, not the LoadInst. Having said that, I considered changing the this->LI name into sth else since LI shadows LI in GVN::runImpl as well, but thought this is an unrelated change. Happy to submit this as well.
Ah right, I didn't look carefully enough. It seems a very unfortunate name clash, but I guess this->LI is fine.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73804/new/

https://reviews.llvm.org/D73804