[PATCH] D73804: [GVN] Add GVNOption to control load-pre more fine-grained.

[Hendrik Greving via Phabricator via llvm-commits]

hgreving marked an inline comment as done.
hgreving added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1406
     return false;
+  if (!isLoadInLoopPREEnabled() && this->LI &&
+      this->LI->getLoopFor(LI->getParent()))
----------------
fhahn wrote:
> nit: drop unnecessary this-> ?
This is testing the LoopInfo, not the LoadInst. Having said that, I considered changing the this->LI name into sth else since LI shadows LI in GVN::runImpl as well, but thought this is an unrelated change. Happy to submit this as well.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73804/new/

https://reviews.llvm.org/D73804