[PATCH] D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 31 12:08:37 PST 2020


mehdi_amini added inline comments.


================
Comment at: mlir/tools/mlir-opt/CMakeLists.txt:15
   mlir-opt.cpp
 )
+target_link_libraries(MLIRMlirOpt ${LIB_LIBS})
----------------
Why is this a library? It seems not used right now.

(I see it is passed in the link of `mlir-opt` below, but that seems like a no-op since the only source file for the library is also passed directly as an object to this target)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73778/new/

https://reviews.llvm.org/D73778





More information about the llvm-commits mailing list