[PATCH] D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar added inline comments.


================
Comment at: mlir/include/mlir/Support/MlirOpt.h:1
-//===- MlirOptMain.h - MLIR Optimizer Driver main ---------------*- C++ -*-===//
+//===- MlirOpt.h - MLIR Optimizer Driver main -------------------*- C++ -*-===//
 //
----------------
s/main/entry point/ (especially if we remove other main references).


================
Comment at: mlir/include/mlir/Support/MlirOpt.h:25
 
-LogicalResult MlirOptMain(llvm::raw_ostream &os,
-                          std::unique_ptr<llvm::MemoryBuffer> buffer,
-                          const PassPipelineCLParser &passPipeline,
-                          bool splitInputFile, bool verifyDiagnostics,
-                          bool verifyPasses);
+LogicalResult MlirOpt(llvm::raw_ostream &os,
+                      std::unique_ptr<llvm::MemoryBuffer> buffer,
----------------
This was chosen this way to match TableGenMain entry point specification.

My preference would be to just update the CMake files without renaming the file or function: this feels stylistic with no real increase in clarity but would require updating all callers in dependent project. That way you get the consistency between cmake and bazel without further changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73778/new/

https://reviews.llvm.org/D73778