[PATCH] D73620: Add 'gpu.terminator' operation.

[Stephan Herhut via Phabricator via llvm-commits]

herhut added a comment.
Herald added a subscriber: Joonsoo.

In D73620#1850048 <https://reviews.llvm.org/D73620#1850048>, @mehdi_amini wrote:

> Why was this committed while we're discussing here?


I misunderstood the comment it seems. I though the idea was that gpu.return should be replaced by a generalized return. From reading the discussion on 'std.return' I assumed this was meant to become a generalized way of returning from a function-like structure.

This change prepares this by splitting terminators that are function like, especially in the sense that their return operands correspond to the parent operation's result value. For the return form a launchOp, this is not the case. Currently, launchOp does not yield any value but that will change soon when we start making things asynchronous. So it does not contradict the work on a generic return.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73620/new/

https://reviews.llvm.org/D73620