[PATCH] D73230: [X86][ELF] Prefer to lower MC_GlobalAddress operands to .Lfoo$local

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D73230#1850895 <https://reviews.llvm.org/D73230#1850895>, @rnk wrote:

> In D73230#1850841 <https://reviews.llvm.org/D73230#1850841>, @MaskRay wrote:
>
> > -fpic/-fPIC does not set `dso_local` so this change does not affect that compile model.
>
>
> Yep, that's how it's supposed to work. :)
>
> lgtm


Thanks!

When -fsemantic-interposition is ready, I want to check if we can do some aggressive thing: infer dso_local for -fPIC, i.e. require -fPIC users to specify -fsemantic-interposition to get the interposition behavior.

As the summary of D73228 <https://reviews.llvm.org/D73228> says, the existing `-fno-semantic-interposition` behaviors in various IPO optimization and the previous assembly behavior may have given us enough license to do this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73230/new/

https://reviews.llvm.org/D73230