[PATCH] D73230: [X86][ELF] Prefer to lower MC_GlobalAddress operands to .Lfoo$local

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 17:28:34 PST 2020


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

In D73230#1850841 <https://reviews.llvm.org/D73230#1850841>, @MaskRay wrote:

> -fpic/-fPIC does not set `dso_local` so this change does not affect that compile model.


Yep, that's how it's supposed to work. :)

lgtm


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73230/new/

https://reviews.llvm.org/D73230





More information about the llvm-commits mailing list