[PATCH] D69808: [RISCV GlobalISel] Add lowerReturn for calling conv.
    weiwei via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Jan 30 08:50:44 PST 2020
    
    
  
wwei marked an inline comment as done.
wwei added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVCallLowering.cpp:101
+
+  TLI.analyzeOutputArgs(MF, CCInfo, Outs, true, nullptr);
+  updateArgLocInfo(ArgLocs, Outs);
----------------
lewis-revill wrote:
> Nitpick: add the `/*IsRet=*/` comment.
> `TLI.analyzeOutputArgs(MF, CCInfo, Outs, /*IsRet=*/true, nullptr);`
done
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69808/new/
https://reviews.llvm.org/D69808
    
    
More information about the llvm-commits
mailing list