[PATCH] D69808: [RISCV GlobalISel] Add lowerReturn for calling conv.

weiwei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 08:50:44 PST 2020


wwei marked an inline comment as done.
wwei added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/GlobalISel/irtranslator-calllowering.ll:1
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc -mtriple=riscv32 -global-isel -stop-after=irtranslator -verify-machineinstrs < %s \
----------------
lewis-revill wrote:
> wwei wrote:
> > lewis-revill wrote:
> > > Nitpick: no longer true with these additions.
> > I don't understand why many test files add this assertion. So is your suggestion that we can remove this assertion?
> Yes the comment can be removed. This is added when the test file `CHECK` annotations are automatically added using that tool.
removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69808/new/

https://reviews.llvm.org/D69808





More information about the llvm-commits mailing list