[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

@vsk Thanks a lot for sharing this!

> (however the machine was not stabilized for perf measurements)

What can be the reason of that?

I have also measure the impact on the size, build time and debug location coverage, on the `LLVM` built binaries with/out the feature. I see that there is no build time difference, the size of the binaries was increased a bit, but it is also minor.

1. `llc` binary
  - with no entry values: `.debug_loc`      241Mi  (21.3% of the whole binary)
  - with entry values: `.debug_loc`      245Mi  (21.5%  of the whole binary)
2. `lldb` binary
  - with no entry values: `.debug_loc`      4.17Mi  (34.1% of the whole binary)
  - with entry values: `.debug_loc`      4.23Mi  (34.3%  of the whole binary)

(Please find additional numbers within the file shared.)

The debug location coverage increased (got with the `llvm-locstats --only-formal-parameters --compare` on the `lldb` binaries built with/out the entry values):
F11263693: locstats.png <https://reviews.llvm.org/F11263693>

Please find the additional numbers regarding the debug location improvements within the `measurements-debug-entry-vals.txt`.
F11263701: measurements-debug-entry-vals.txt <https://reviews.llvm.org/F11263701>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73534/new/

https://reviews.llvm.org/D73534