[PATCH] D73267: Fix helptext for opt/llc after 14fc20ca6
Nemanja Ivanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 30 04:41:35 PST 2020
nemanjai marked 3 inline comments as done.
nemanjai added inline comments.
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:91
+ "\njcc indicates conditional jumps"
+ "\nfused indicates fusedconditional jumps"
+ "\njmp indicates unconditional jumps"
----------------
annita.zhang wrote:
> fused conditional (add a space between)
Oops, I'll fix that. Thanks.
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:92
+ "\nfused indicates fusedconditional jumps"
+ "\njmp indicates unconditional jumps"
+ "\ncall indicates direct and indirect calls"
----------------
annita.zhang wrote:
> indicates direct unconditional jumps
Will do.
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:95
+ "\nret indicates rets"
+ "\nindirect indicates indirect jumps"),
+ cl::value_desc("jcc, fused, jmp, call, ret, indirect"),
----------------
annita.zhang wrote:
> indicates indirect unconditional jumps
Will do.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73267/new/
https://reviews.llvm.org/D73267
More information about the llvm-commits
mailing list