[PATCH] D73267: Fix helptext for opt/llc after 14fc20ca6

annita.zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 01:12:16 PST 2020


annita.zhang accepted this revision.
annita.zhang added a comment.

Refine the wordings to make it clearer. Other than that, LGTM.



================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:91
+             "\njcc      indicates conditional jumps"
+             "\nfused    indicates fusedconditional jumps"
+             "\njmp      indicates unconditional jumps"
----------------
fused conditional (add a space between)


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:92
+             "\nfused    indicates fusedconditional jumps"
+             "\njmp      indicates unconditional jumps"
+             "\ncall     indicates direct and indirect calls"
----------------
indicates direct unconditional jumps


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:95
+             "\nret      indicates rets"
+             "\nindirect indicates indirect jumps"),
+    cl::value_desc("jcc, fused, jmp, call, ret, indirect"),
----------------
indicates indirect unconditional jumps


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73267/new/

https://reviews.llvm.org/D73267





More information about the llvm-commits mailing list